test_runner: default to spec reporter when on TTY environment - #46969
Closed
MoLow wants to merge 0 commit into
Closed
test_runner: default to spec reporter when on TTY environment#46969MoLow wants to merge 0 commit into
MoLow wants to merge 0 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
benjamingr
approved these changes
Mar 6, 2023
cjihrig
approved these changes
Mar 6, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
force-pushed
the
default-to-spec-reporter
branch
from
9d45a7e to
8bcec34
Compare
March 8, 2023 00:15
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
MoLow
force-pushed
the
default-to-spec-reporter
branch
2 times, most recently
from
36249a4 to
41de945
Compare
March 8, 2023 01:27
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46969 ✔ Done loading data for nodejs/node/pull/46969 ----------------------------------- PR info ------------------------------------ Title test_runner: default to spec reporter when on TTY environment (#46969) Author Moshe Atlow (@MoLow) Branch MoLow:default-to-spec-reporter -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, test_runner Commits 1 - test_runner: default to spec reporter when on TTY environment Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/46969 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46969 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test_runner: default to spec reporter when on TTY environment ℹ This PR was created on Mon, 06 Mar 2023 10:31:29 GMT ✔ Approvals: 2 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/46969#pullrequestreview-1326024666 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46969#pullrequestreview-1326665588 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-03-08T06:07:00Z: https://ci.nodejs.org/job/node-test-pull-request/50271/ - Querying data for job/node-test-pull-request/50271/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4363465881 |
Sorry, something went wrong.
MoLow
added a commit
that referenced
this pull request
Mar 8, 2023
PR-URL: #46969 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow
force-pushed
the
default-to-spec-reporter
branch
from
41de945 to
9960c36
Compare
March 8, 2023 22:23
This was referenced Mar 9, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46969 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
24 tasks
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46969 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46969 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will change the default reporter to be humanly readable when in an environment with TTY