FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

typings: improve `primordials` typings by aduh95 · Pull Request #46970 · nodejs/node · GitHub

/ node Public

typings: improve primordials typings - #46970

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:primordials-typings
Mar 8, 2023
Merged

typings: improve primordials typings#46970
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:primordials-typings

Conversation

aduh95 commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot added needs-ci PRs that need a full CI run. typings labels Mar 6, 2023

MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 6, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023

Copy link
Copy Markdown
Collaborator

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 8, 2023
nodejs-github-bot merged commit 0c46051 into nodejs:main Mar 8, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0c46051

aduh95 deleted the primordials-typings branch March 8, 2023 10:49
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
PR-URL: #46970
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. typings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL