tools: automate cares update - #46993
Merged
nodejs-github-bot merged 6 commits intoMar 10, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
yes! I moved cares to the new folder, will update it like in the pr you linked. |
Sorry, something went wrong.
tony-go
approved these changes
Mar 7, 2023
tony-go
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
richardlau
reviewed
Mar 7, 2023
Comment thread
tools/dep_updaters/update-cares.sh
Outdated
anonrig
reviewed
Mar 7, 2023
Comment thread
tools/dep_updaters/update-cares.sh
Outdated
Comment thread
tools/dep_updaters/update-cares.sh
Comment thread
tools/dep_updaters/update-cares.sh
RafaelGSS
reviewed
Mar 7, 2023
Comment thread
tools/dep_updaters/update-cares.sh
aduh95
reviewed
Mar 7, 2023
Comment thread
doc/contributing/maintaining-c-ares.md
Outdated
aduh95
reviewed
Mar 7, 2023
Comment thread
tools/dep_updaters/update-c-ares.sh
Outdated
anonrig
approved these changes
Mar 7, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
approved these changes
Mar 9, 2023
RafaelGSS
approved these changes
Mar 10, 2023
benjamingr
approved these changes
Mar 10, 2023
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #46993 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #46993 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
PR-URL: #46993 Refs: nodejs/security-wg#828 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828