FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix lint error by MoLow · Pull Request #47007 · nodejs/node · GitHub

/ node Public

src: fix lint error - #47007

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-cpp-lint
Closed

src: fix lint error#47007
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:fix-cpp-lint

Conversation

MoLow commented Mar 8, 2023

Copy link
Copy Markdown
Member

a lint error was introduced here e5933c8

MoLow requested a review from joyeecheung March 8, 2023 00:43
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 8, 2023
MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2023

github-actions Bot commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

MoLow added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 8, 2023

MoLow commented Mar 8, 2023

Copy link
Copy Markdown
Member Author

closing in favor of #47007

MoLow closed this Mar 8, 2023
MoLow deleted the fix-cpp-lint branch March 8, 2023 00:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL