FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix typo in process.env accessor error message by moritzraho · Pull Request #47014 · nodejs/node · GitHub

/ node Public

src: fix typo in process.env accessor error message - #47014

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
moritzraho:patch-1
Apr 16, 2023
ConversationCommits (1)ChecksFiles changed
Merged

src: fix typo in process.env accessor error message#47014
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
moritzraho:patch-1

Conversation

moritzraho commented Mar 8, 2023

Copy link
Copy Markdown
Contributor

Tiny commit to fix a missing white space in the error message "'process.env' does not accept anaccessor(getter/setter) descriptor".

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 8, 2023

anonrig commented Mar 8, 2023

Copy link
Copy Markdown
Member

Can you update your commit message to conform to commit style guidelines? @moritzraho

lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 27, 2023

nodejs-github-bot commented Mar 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50623/

This was referenced Mar 30, 2023
Open
Open

lpinca commented Apr 10, 2023

Copy link
Copy Markdown
Member

@moritzraho can you please fix the lint issue?

moritzraho commented Apr 11, 2023

Copy link
Copy Markdown
Contributor Author

@lpinca yup done

nodejs-github-bot commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51127/

nodejs-github-bot commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51140/

benjamingr commented Apr 11, 2023

Copy link
Copy Markdown
Member

I hate to bring it up - but can someone please tell me it's OK for this not to be semver-major because even though it changes an error message it's extremely unlikely fro this particular error and error message to be checked in a way where this can break stuff in practice?

cjihrig commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

It changes the error message, but it doesn't change the error code, so this shouldn't need to be semver-major.

This was referenced Apr 12, 2023
Open
Open

nodejs-github-bot commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51283/

nodejs-github-bot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51297/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 16, 2023
nodejs-github-bot merged commit 070c9a8 into nodejs:main Apr 16, 2023

nodejs-github-bot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in 070c9a8

github-actions Bot mentioned this pull request Apr 18, 2023
Open
35 tasks
targos pushed a commit that referenced this pull request May 2, 2023
src: fix typo in process.env accessor error message
ba255ed 
PR-URL: #47014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
src: fix typo in process.env accessor error message
ed22f54 
PR-URL: #47014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
src: fix typo in process.env accessor error message
175b78b 
PR-URL: nodejs#47014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
lpinca lpinca approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL