doc,test: extend the list of platforms supported by single-executables - #47026
Merged
nodejs-github-bot merged 3 commits intoMar 11, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Now that nodejs#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This comment was marked as outdated.
targos
reviewed
Mar 9, 2023
Comment thread
doc/api/single-executable-applications.md
Outdated
Refs: nodejs#47026 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
tony-go
approved these changes
Mar 9, 2023
tony-go
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm & my comment
Sorry, something went wrong.
Comment thread
test/parallel/test-single-executable-application.js
Outdated
Refs: nodejs#47026 (comment) Co-authored-by: Tony Gorez <gorez.tony@gmail.com>
debadree25
approved these changes
Mar 9, 2023
Copy link
Copy Markdown
Contributor
|
(unrelated) Are there any tracking issues for the failures in these different platforms? would love to try my hand 😅 |
Sorry, something went wrong.
cjihrig
approved these changes
Mar 9, 2023
Copy link
Copy Markdown
Member
Author
I haven't spent time investigating the remaining failures to come up with issues that are descriptive enough yet, maybe you could help out with that? |
Sorry, something went wrong.
This comment was marked as outdated.
Copy link
Copy Markdown
Contributor
Best way to reproduce these locally? using a vm? if yes any recommendations on that? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I normally use Parallels if I have to use a VM. If an issue still doesn't repro there, we can request access to a system in the build repo like I did in nodejs/build#3207. |
Sorry, something went wrong.
aymen94
approved these changes
Mar 10, 2023
mcollina
approved these changes
Mar 10, 2023
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Mar 13, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2023
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #47026 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Now that nodejs/node#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#47026 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
Now that nodejs/node#46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#47026 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #46934 has landed, we can extend the list of platforms and architectures where we can run the single-executable test.
(Initially tested this in #46868)
cc @nodejs/single-executable