doc: remove remaining SSL_OP_NETSCAPE_*_BUG - #47066
Merged
nodejs-github-bot merged 1 commit intoMar 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: nodejs#46954 Refs: openssl/openssl#20443
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
Sorry, something went wrong.
panva
approved these changes
Mar 13, 2023
richardlau
approved these changes
Mar 13, 2023
anonrig
approved these changes
Mar 13, 2023
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Mar 13, 2023
None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1. It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === (a | b) for (small) integers a and b. Refs: nodejs#46954 Refs: nodejs#47066
targos
pushed a commit
that referenced
this pull request
Mar 14, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: #46954 Refs: openssl/openssl#20443 PR-URL: #47066 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
None of these constants have any effect in recent OpenSSL versions, not even in Node.js release lines that still use OpenSSL 1.1.1. It is likely rare that these options are still used (intentionally), and removing them is unlikely to break any existing applications. These constants can only be passed to the secureOptions option of tls.createSecureContext() and related APIs, and a value of undefined will be ignored. Similarly, if a bitwise combination of multiple options is used, undefined constants will not change the behavior because (a | undefined | b) === (a | b) for (small) integers a and b. Refs: #46954 Refs: #47066 PR-URL: #47073 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Apr 11, 2023
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443. Refs: #46954 Refs: openssl/openssl#20443 PR-URL: #47066 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I missed these two in db81af6 because I went by OpenSSL's list of obsolete flags, which turned out to be incomplete. See openssl/openssl#20443.
Refs: #46954
Refs: openssl/openssl#20443