FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: return UV_EAI_NODATA on empty lookup by cjihrig · Pull Request #4715 · nodejs/node · GitHub

/ node Public

src: return UV_EAI_NODATA on empty lookup - #4715

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dns
ConversationCommits (1)ChecksFiles changed
Closed

src: return UV_EAI_NODATA on empty lookup#4715
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:dns

Conversation

cjihrig commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

AfterGetAddrInfo() can potentially return an empty array of results without setting an error value. The JavaScript layer expects the array to have at least one value if an error is not returned. This commit sets a UV_EAI_NODATA error when an empty result array is detected.

Fixes: #4545

R= @evanlucas

src: return UV_EAI_NODATA on empty lookup
3267d9f 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: nodejs#4545

evanlucas commented Jan 15, 2016

Copy link
Copy Markdown
Contributor

LGTM if it works

mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem. labels Jan 15, 2016

silverwind commented Jan 16, 2016

Copy link
Copy Markdown
Contributor

@allthetime can you possibly verify?

bnoordhuis commented Jan 17, 2016

Copy link
Copy Markdown
Member

LGTM

cjihrig commented Jan 18, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/1282/

Jenkins issues. Second run: https://ci.nodejs.org/job/node-test-pull-request/1290/

saghul commented Jan 18, 2016

Copy link
Copy Markdown
Member

LGTM

cjihrig added a commit that referenced this pull request Jan 18, 2016
src: return UV_EAI_NODATA on empty lookup
8bad519 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: #4545
PR-URL: #4715
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

cjihrig commented Jan 18, 2016

Copy link
Copy Markdown
Contributor Author

CI is all green. Thanks for the reviews! Landed in 8bad519.

cjihrig closed this Jan 18, 2016
cjihrig deleted the dns branch January 18, 2016 15:01

jasnell commented Jan 18, 2016

Copy link
Copy Markdown
Member

This is fine, but would it be possible to also get a test case added to go along with this?

cjihrig commented Jan 18, 2016

Copy link
Copy Markdown
Contributor Author

I'd be happy to, but haven't been able to reproduce. I had to force n to zero during testing to make sure it was working.

jasnell commented Jan 18, 2016

Copy link
Copy Markdown
Member

yep, understood.

evanlucas mentioned this pull request Jan 18, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jan 18, 2016
src: return UV_EAI_NODATA on empty lookup
3af206d 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: #4545
PR-URL: #4715
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins mentioned this pull request Mar 10, 2016
Closed

MylesBorins commented Mar 10, 2016

Copy link
Copy Markdown
Contributor

Is this something we might want for lts?

jasnell commented Mar 11, 2016

Copy link
Copy Markdown
Member

SGTM

rvagg commented Mar 14, 2016

Copy link
Copy Markdown
Member

+1 for lts

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
src: return UV_EAI_NODATA on empty lookup
d7dcd9a 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: #4545
PR-URL: #4715
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
src: return UV_EAI_NODATA on empty lookup
7c3b844 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: #4545
PR-URL: #4715
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
src: return UV_EAI_NODATA on empty lookup
7e0b828 
AfterGetAddrInfo() can potentially return an empty array of
results without setting an error value. The JavaScript layer
expects the array to have at least one value if an error is
not returned. This commit sets a UV_EAI_NODATA error when an
empty result array is detected.

Fixes: nodejs#4545
PR-URL: nodejs#4715
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL