cherry-pick eslint update to v4.x - #4721
Closed
targos wants to merge 6 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
On case-insensitive platorms, the Debug/ rule catches the debug module under npm and eslint. PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
The no-reserved-keys rule doesn't exist anymore and we don't need ES3 compatibility. escape and unescape are now known by eslint. --reset flag was removed and it is now the default behavior. PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
With an indentation style of two spaces, it is not possible to indent multiline variable declarations by four spaces. Instead, the var keyword is used on every new line. Use const instead of var where applicable for changed lines. PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
Replace var keyword with const or let. PR-URL: nodejs#2286 Reviewed-By: Roman Reiss <me@silverwind.io>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM, but since this is such a huge edit I propose waiting to land until after 4.2.5. We'll be spinning up a 4.3.0 soon after. /cc @nodejs/lts |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.