create vee-eight-4.9 branch - #4722
Conversation
Sorry, something went wrong.
|
@targos Can you cherry pick e9f499e and b83a33f as the solution for nodejs/build#304? |
Sorry, something went wrong.
|
Oh, I see that you already added that commit to your list. You can ignore the previous message. |
Sorry, something went wrong.
|
@targos I updated to 4.9.385.11, and added some commits here: https://github.com/ofrobots/node/commits/vee-eight-4.9. With this the tests are now fully passing. There are still some deprecation warnings that need to be ironed out, but this is looking good to land into the vee-eight-4.9 branch. Your commits LGTM. |
Sorry, something went wrong.
|
@ofrobots thanks, I picked up your branch here |
Sorry, something went wrong.
|
thanks @ofrobots. I updated the proxy tab-completion test. |
Sorry, something went wrong.
Sorry, something went wrong.
|
/cc @nodejs/addon-api, also see #4869, I haven't looked at this but it sounds like there's enough movement that it impacts NAN. Node.js v6 will be out with at least V8 v4.9, hopefully V8 v5.0. |
Sorry, something went wrong.
|
Part of the problem here has been that we are only now getting to integrating V8 4.9 with Node.js. V8 4.9 is not stable yet, so if there is a deal breaker deprecation, let's provide the feedback to the V8 team and see what can be one. |
Sorry, something went wrong.
|
I pushed two new V8 deprecation-related commits. Perhaps we could go with a review of the PR as it is now, merge it into vee-eight-4.9 and continue the integration from there ? |
Sorry, something went wrong.
|
@targos Your commits LGTM. Someone else will have to review mine. |
Sorry, something went wrong.
|
ping @nodejs/v8 for additional review |
Sorry, something went wrong.
|
@targos perhaps you can review my commits. |
Sorry, something went wrong.
|
Style nits but otherwise LGTM. |
Sorry, something went wrong.
Sorry, something went wrong.
Pick up the current branch head for V8 4.9 v8/v8@1ecba0f PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
- An error message changed for undefined references - `let` is now allowed in sloppy mode - ES2015 proxies are shipped and the `Proxy` global is now a function PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Proxies support is now complete in V8. The tests needed slight modification to match the spec implementation. PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Proxies support is now complete in V8. The tests needed slight modification to match the spec implementation. PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Pick up the current branch head for V8 4.9 v8/v8@1ecba0f PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
- An error message changed for undefined references - `let` is now allowed in sloppy mode - ES2015 proxies are shipped and the `Proxy` global is now a function PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Proxies support is now complete in V8. The tests needed slight modification to match the spec implementation. PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: nodejs#4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Pick up the current branch head for V8 4.9 v8/v8@1ecba0f PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
- An error message changed for undefined references - `let` is now allowed in sloppy mode - ES2015 proxies are shipped and the `Proxy` global is now a function PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Proxies support is now complete in V8. The tests needed slight modification to match the spec implementation. PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
PR-URL: #4722 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
The V8 team just cut the 4.9 branch so I started working on its integration.
That's still a work in progress but I'm creating the PR now because I have issues with a failing test and we will have to discuss about what we do with the V8 APIs that have been deprecated in 4.9 (as an example, I fixed the deprecation warning about String::NewFromOneByte here).
The branch cannot be built without manually copying the trace_event dependency (see nodejs/build#304)
cc @ofrobots @nodejs/v8