FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: run doctool tests in parallel by joyeecheung · Pull Request #47273 · nodejs/node · GitHub

/ node Public

test: run doctool tests in parallel - #47273

Closed
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:parallel-test
ConversationCommits (1)ChecksFiles changed
Closed

test: run doctool tests in parallel#47273
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:parallel-test

Conversation

joyeecheung commented Mar 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I don't see why we can't run doctool tests and wpt in parallel, so make them run in parallel.

About other non-parallel tests:

  • benchmark: needs some refactoring in net and tls benchmarks to stop using common.PORT
  • embedding: there is only one test, so making it run in parallel doesn't add much
  • internet: needs refactoring to stop using common.PORT
  • known-issues: usually not run anyway
  • tick-processor: this does not even work locally for me?
  • pummel: takes a long time to run anyway, which is its point, and I am not sure if it can actually be run in parallel

Refs: #47146

EDIT: removed the WPT changes in favor of #47283

nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Mar 27, 2023

nodejs-github-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50632/

debadree25 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 28, 2023
targos approved these changes Mar 28, 2023
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd prefer us to make the WPT runner itself spawn parallel workers, but this change is good for now.

This comment was marked as resolved.

Sign in to view
panva mentioned this pull request Mar 28, 2023
Merged
panva added the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023

panva commented Mar 30, 2023

Copy link
Copy Markdown
Member

Adding blocked PRs that are blocked by other issues or PRs. until I resolve an issue with the WPT Runner writing WPT Report. It is not currently set up to handle parallel execution. Shouldn't take long to unblock.

joyeecheung commented Mar 30, 2023

Copy link
Copy Markdown
Member Author

I can also just remove the WPT changes

joyeecheung removed the blocked PRs that are blocked by other issues or PRs. label Mar 30, 2023
joyeecheung changed the title test: run doctool tests and wpt tests in parallel test: run doctool tests in parallel Mar 30, 2023

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50702/

panva commented Mar 30, 2023

Copy link
Copy Markdown
Member

Ok, i'll re-add them to #47283

github-actions Bot mentioned this pull request Mar 31, 2023
Open
34 tasks

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50749/

github-actions Bot mentioned this pull request Apr 1, 2023
Open
38 tasks

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50776/

This was referenced Apr 2, 2023
Open
Open

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50874/

joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023

joyeecheung commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

Landed in cd36f6e

joyeecheung closed this Apr 4, 2023
joyeecheung removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
joyeecheung added a commit that referenced this pull request Apr 4, 2023
test: run doctool tests in parallel
cd36f6e 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
test: run doctool tests in parallel
627e339 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
test: run doctool tests in parallel
032ea70 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
test: run doctool tests in parallel
94bc64c 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
test: run doctool tests in parallel
130420b 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
test: run doctool tests in parallel
2356e10 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: run doctool tests in parallel
397881a 
PR-URL: #47273
Refs: #47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test: run doctool tests in parallel
3c157cb 
PR-URL: nodejs#47273
Refs: nodejs#47146
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL