FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add missing commits to v4.x-staging by Trott · Pull Request #4730 · nodejs/node · GitHub

/ node Public

Add missing commits to v4.x-staging - #4730

Closed
Trott wants to merge 2 commits into
nodejs:v4.x-stagingfrom
Trott:v4-missing
ConversationCommits (2)ChecksFiles changed
Closed

Add missing commits to v4.x-staging#4730
Trott wants to merge 2 commits into
nodejs:v4.x-stagingfrom
Trott:v4-missing

Conversation

Trott commented Jan 17, 2016

Copy link
Copy Markdown
Member

Adds a pair of commits that have landed in master that are currently not in v4.x-staging.

Ref: #4698

Trott added 2 commits January 17, 2016 09:37
test: mark http-pipeline-flood flaky
ea58e39 
test-http-pipeline-flood has been flaky on Windows for some time.
Hopefully, nodejs#2862 fixes it and
lands soon, but until then, let's mark it as flaky.

PR-URL: nodejs#3616
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
test: refactor test-http-pipeline-flood
2ac2a24 
This extends fixes for test-https-pipeline-flood to hopefully fully
eliminate its flakiness on Windows in our continuous integration
process.

PR-URL: nodejs#3636
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Trott added test Issues and PRs related to the tests. lts Issues and PRs related to Long Term Support releases. labels Jan 17, 2016
Trott mentioned this pull request Jan 17, 2016
Closed

rvagg commented Jan 18, 2016

Copy link
Copy Markdown
Member

that's what I see for this, no changes .. ?

Trott commented Jan 18, 2016

Copy link
Copy Markdown
Member Author

Ah, I missed that a third commit moved the file into parallel and that commit has already landed on v4.x-staging. So the sum total of these two commits with that commit would be no change. Closing.

Trott closed this Jan 18, 2016

MylesBorins commented Jan 18, 2016

Copy link
Copy Markdown
Contributor

Can you add do-not-land-onv4.x label to the commits in question?
On Jan 18, 2016 12:12 AM, "Rich Trott" notifications@github.com wrote:

Closed #4730 #4730.

—
Reply to this email directly or view it on GitHub
#4730 (comment).

Trott commented Jan 18, 2016

Copy link
Copy Markdown
Member Author

@thealphanerd I've added the label to the relevant pull requests (#3616 and #3636) and removed the other v4.x labels from #3636.

Trott mentioned this pull request Mar 9, 2016
Closed
MylesBorins removed their assignment Dec 27, 2016
Trott deleted the v4-missing branch January 13, 2022 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lts Issues and PRs related to Long Term Support releases. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL