FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sea: fix memory leak detected by asan by RaisinTen · Pull Request #47309 · nodejs/node · GitHub

/ node Public

sea: fix memory leak detected by asan - #47309

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RaisinTen:sea-fix-memory-leak-detected-by-asan
Apr 3, 2023
ConversationCommits (2)ChecksFiles changed
Merged

sea: fix memory leak detected by asan#47309
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
RaisinTen:sea-fix-memory-leak-detected-by-asan

Conversation

RaisinTen commented Mar 30, 2023

Copy link
Copy Markdown
Member

No description provided.

sea: fix memory leak detected by asan
e1cf8bd 
Signed-off-by: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot commented Mar 30, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/single-executable

nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Mar 30, 2023
RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

This comment was marked as outdated.

Sign in to view
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Mar 30, 2023

This comment was marked as outdated.

Sign in to view
joyeecheung approved these changes Mar 30, 2023
View reviewed changes
Comment thread src/node_sea.cc
sea: refactor code to be easier to read
d12133c 
Refs: nodejs#47309 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
RaisinTen added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 30, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 30, 2023

This comment was marked as outdated.

Sign in to view
mhdawson approved these changes Mar 30, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

github-actions Bot mentioned this pull request Mar 31, 2023
Open
34 tasks

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50729/

This was referenced Apr 1, 2023
Open
Open
RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
nodejs-github-bot merged commit 5db08cf into nodejs:main Apr 3, 2023

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5db08cf

RaisinTen deleted the sea-fix-memory-leak-detected-by-asan branch April 3, 2023 08:10
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
sea: fix memory leak detected by asan
193e12b 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
sea: fix memory leak detected by asan
071929b 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
sea: fix memory leak detected by asan
54e35a8 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
sea: fix memory leak detected by asan
33b0906 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
sea: fix memory leak detected by asan
0621bdb 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
sea: fix memory leak detected by asan
7306b0f 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: nodejs#47309
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
joyeecheung joyeecheung approved these changes
+4 more reviewers
mhdawson mhdawson approved these changes
aymen94 aymen94 approved these changes
tony-go tony-go approved these changes
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL