tools: add missing pinned dependencies - #47346
Merged
nodejs-github-bot merged 2 commits intoApr 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
cc @nodejs/security-wg |
Sorry, something went wrong.
targos
reviewed
Mar 31, 2023
Comment thread
deps/openssl/config/Dockerfile
Outdated
4 tasks
Signed-off-by: mateonunez <mateonunez95@gmail.com>
RafaelGSS
approved these changes
Apr 2, 2023
mhdawson
approved these changes
Apr 13, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
fraxken
approved these changes
Apr 13, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47346 ✔ Done loading data for nodejs/node/pull/47346 ----------------------------------- PR info ------------------------------------ Title tools: add missing pinned dependencies (#47346) Author Mateo Nunez (@mateonunez) Branch mateonunez:tools/pinned-dependencies -> nodejs:main Labels meta, openssl, needs-ci, dependencies, commit-queue-squash Commits 2 - tools: add missing pinned dependencies - tools: revert Dockerfile pinned dependency Committers 1 - mateonunez PR-URL: https://github.com/nodejs/node/pull/47346 Reviewed-By: Rafael Gonzaga Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47346 Reviewed-By: Rafael Gonzaga Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 31 Mar 2023 15:39:34 GMT ✔ Approvals: 2 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47346#pullrequestreview-1368084021 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47346#pullrequestreview-1383528055 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4690388111 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47346 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47346 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47346 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR aims to increase the score of OpenSSF by pinning some missing dependencies.
Pinned dependencies:
To get the 10 score on the Pinned-Dependencies scorecard section, some other application dependencies (npm and pip) would have to be pinned. But on this, I decided to investigate the correct way to pin them before creating a PR.