test: verify tracePromise does not do runStores by Qard · Pull Request #47349 · nodejs/node · GitHub

Just improving the test for this slightly. Chose to do a follow-up PR so as to not tempt fate with CI so soon before release cut-off. Requesting fast-track for this.

CI: https://ci.nodejs.org/job/node-test-pull-request/50761/

Fast-track has been requested by @Qard. Please 👍 to approve.

CI: https://ci.nodejs.org/job/node-test-pull-request/50765/

CI: https://ci.nodejs.org/job/node-test-pull-request/50766/

CI: https://ci.nodejs.org/job/node-test-pull-request/50774/

CI: https://ci.nodejs.org/job/node-test-pull-request/50778/

…-run-stores.js Co-authored-by: Rich Trott <rtrott@gmail.com>

CI: https://ci.nodejs.org/job/node-test-pull-request/50780/

CI: https://ci.nodejs.org/job/node-test-pull-request/50801/

CI: https://ci.nodejs.org/job/node-test-pull-request/50807/

Commit Queue failed

- Loading data for nodejs/node/pull/47349 ✔ Done loading data for nodejs/node/pull/47349 ----------------------------------- PR info ------------------------------------ Title test: verify tracePromise does not do runStores (#47349) Author Stephen Belanger (@Qard) Branch Qard:improve-tracing-channel-run-stores-tests -> nodejs:main Labels test, fast-track, needs-ci, diagnostics_channel Commits 2 - test: verify tracePromise does not do runStores - Update test/parallel/test-diagnostics-channel-tracing-channel-promise… Committers 2 - Stephen Belanger - GitHub PR-URL: https://github.com/nodejs/node/pull/47349 Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47349 Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 31 Mar 2023 18:41:01 GMT ✔ Approvals: 3 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367513775 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367567448 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47349#pullrequestreview-1367811162 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-04-02T06:02:27Z: https://ci.nodejs.org/job/node-test-pull-request/50807/ - Querying data for job/node-test-pull-request/50807/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 47349 From https://github.com/nodejs/node * branch refs/pull/47349/merge -> FETCH_HEAD ✔ Fetched commits as 85705a47958c..e9a266754cac -------------------------------------------------------------------------------- [main 20fcf19366] test: verify tracePromise does not do runStores Author: Stephen Belanger Date: Fri Mar 31 11:39:10 2023 -0700 1 file changed, 11 insertions(+), 4 deletions(-) [main 6fb6ce54ab] Update test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js Author: Stephen Belanger Date: Fri Mar 31 22:44:09 2023 -0700 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: verify tracePromise does not do runStores

PR-URL: #47349
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 5f831b34c5] test: verify tracePromise does not do runStores
Author: Stephen Belanger stephen.belanger@datadoghq.com
Date: Fri Mar 31 11:39:10 2023 -0700
1 file changed, 11 insertions(+), 4 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js

Co-authored-by: Rich Trott rtrott@gmail.com
PR-URL: #47349
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

[detached HEAD 4d1fd8588b] Update test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js
Author: Stephen Belanger admin@stephenbelanger.com
Date: Fri Mar 31 22:44:09 2023 -0700
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/4589696191

Landed in cf83cae

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs/node#47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

test: verify tracePromise does not do runStores

5b1ec5c

Qard added test Issues and PRs related to the tests. diagnostics_channel Issues and PRs related to diagnostics channel labels Mar 31, 2023

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 31, 2023

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023

Qard added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 31, 2023

anonrig approved these changes Mar 31, 2023

View reviewed changes

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023

jasnell approved these changes Mar 31, 2023

View reviewed changes

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

github-actions Bot mentioned this pull request Apr 1, 2023

CI Reliability 2023-04-01 nodejs/reliability#536

Open

38 tasks

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

Trott reviewed Apr 1, 2023

View reviewed changes

Comment thread test/parallel/test-diagnostics-channel-tracing-channel-promise-run-stores.js Outdated

Trott approved these changes Apr 1, 2023

View reviewed changes

Update test/parallel/test-diagnostics-channel-tracing-channel-promise…

e9a2667

…-run-stores.js Co-authored-by: Rich Trott <rtrott@gmail.com>

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2023

github-actions Bot mentioned this pull request Apr 2, 2023

CI Reliability 2023-04-02 nodejs/reliability#537

Open

30 tasks

Qard added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023

Qard added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2023

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 2, 2023

github-actions Bot mentioned this pull request Apr 3, 2023

CI Reliability 2023-04-03 nodejs/reliability#538

Open

28 tasks

Qard added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 3, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023

nodejs-github-bot merged commit cf83cae into nodejs:main Apr 3, 2023

github-actions Bot mentioned this pull request Apr 4, 2023

CI Reliability 2023-04-04 nodejs/reliability#539

Open

29 tasks

Qard deleted the improve-tracing-channel-run-stores-tests branch April 4, 2023 15:26

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023

test: verify tracePromise does not do runStores

6ef0e03

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

RafaelGSS mentioned this pull request Apr 6, 2023

v19.9.0 proposal #47441

Merged

RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023

test: verify tracePromise does not do runStores

4ff97ad

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023

test: verify tracePromise does not do runStores

696920d

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023

test: verify tracePromise does not do runStores

4b4336c

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams added the backport-requested-v18.x label Jul 3, 2023

targos pushed a commit that referenced this pull request Nov 10, 2023

test: verify tracePromise does not do runStores

4f78233

PR-URL: #47349 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

test: verify tracePromise does not do runStores by Qard · Pull Request #47349 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: verify tracePromise does not do runStores - #47349

test: verify tracePromise does not do runStores#47349
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Qard:improve-tracing-channel-run-stores-tests

Qard commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

github-actions Bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

test: verify tracePromise does not do runStores by Qard · Pull Request #47349 · nodejs/node · GitHub

Uh oh!

Uh oh!

test: verify tracePromise does not do runStores - #47349

test: verify tracePromise does not do runStores#47349nodejs-github-bot merged 2 commits intonodejs:mainnodejs/node:mainfrom Qard:improve-tracing-channel-run-stores-testsQard/node:improve-tracing-channel-run-stores-testsCopy head branch name to clipboard

Conversation

Qard commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

github-actions Bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Mar 31, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 1, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

Uh oh!

nodejs-github-bot commented Apr 2, 2023

PR-URL: #47349 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com

Co-authored-by: Rich Trott rtrott@gmail.com PR-URL: #47349 Reviewed-By: Yagiz Nizipli yagiz@nizipli.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Rich Trott rtrott@gmail.com

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented Apr 3, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

test: verify tracePromise does not do runStores#47349
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
Qard:improve-tracing-channel-run-stores-tests

PR-URL: #47349
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com

Co-authored-by: Rich Trott rtrott@gmail.com
PR-URL: #47349
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com