tools: add a at here tag for slack messages and update variable for default branch - #47358
tools: add a at here tag for slack messages and update variable for default branch#47358debadree25 wants to merge 2 commits into
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
aduh95
left a comment
There was a problem hiding this comment.
Looking at the Slack message, it looks like github.repository.default_branch is an empty string, could we also fix that?
Sorry, something went wrong.
|
Since the action only runs on the main branch should we just hardcode it? @aduh95 |
Sorry, something went wrong.
|
I think we should use github.ref that would make more sense here. |
Sorry, something went wrong.
|
Seems like github.ref_name is the variable to use ref: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context |
Sorry, something went wrong.
|
added rebase tag to land as two separate logic changes one for the @/here and another for the refname |
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM. I proposed this so I'm definitely in favor. Thanks for doing it! There are over 500 people in that Slack channel and there may be some concern about this being noisy, but I'd prefer we try it and make a determination about it. These kinds of things are exactly the kinds of things I want to be highlighted in that channel, so a notification seems helpful. The other option is to move it to a separate channel, but that risks fragmentation--too many people not bothering to join the alerts channel because they are already in the core channel--that kind of thing.
Sorry, something went wrong.
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This comment was marked as resolved.
Eh, nah, looking more closely, it could definitely be rebased. I'm wrong. (Or at least, both approaches are valid here.) |
Sorry, something went wrong.
|
yeah since one changes the message another fixes the bug where the name branch is not appearing hence landing as two. 😅 |
Sorry, something went wrong.
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#47358 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Adds a @here to the slack message to notify anyone online