FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: remove Python pip --no-user option (#47338) by Trott · Pull Request #47372 · nodejs/node · GitHub

/ node Public

build: remove Python pip --no-user option (#47338) - #47372

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
Trott:reland-47338
Apr 2, 2023
Merged

build: remove Python pip --no-user option (#47338)#47372
aduh95 merged 1 commit into
nodejs:mainfrom
Trott:reland-47338

Conversation

Trott commented Apr 2, 2023

Copy link
Copy Markdown
Member

Python pip no longer has a --no-user option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Apr 2, 2023
Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 2, 2023

github-actions Bot commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

This is a re-landing for #47338.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2023

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Contributor

would the commit title need to be renamed? it still has the PR url

Trott commented Apr 2, 2023

Copy link
Copy Markdown
Member Author

would the commit title need to be renamed? it still has the PR url

Oh, yeah, I should remove that. I'll force push and restart CI. Thanks.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: nodejs#47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

aduh95 commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

Landed in cce5a8c

aduh95 merged commit cce5a8c into nodejs:main Apr 2, 2023
Trott deleted the reland-47338 branch April 2, 2023 21:28
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: #47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Python pip no longer has a `--no-user` option.

Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files
PR-URL: nodejs#47372
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL