FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: color errors only when colors are avilable by MoLow · Pull Request #47394 · nodejs/node · GitHub

/ node Public

test_runner: color errors only when colors are avilable - #47394

Merged
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:fix-spec-reporter-fluke
Apr 4, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: color errors only when colors are avilable#47394
MoLow merged 1 commit into
nodejs:mainfrom
MoLow:fix-spec-reporter-fluke

Conversation

MoLow commented Apr 3, 2023

Copy link
Copy Markdown
Member

Fixes: #47393

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added dont-land-on-v14.x needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 3, 2023
cjihrig approved these changes Apr 3, 2023
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - is it possible to add a test for this behavior?

MoLow commented Apr 3, 2023

Copy link
Copy Markdown
Member Author

LGTM - is it possible to add a test for this behavior?

there is a test, it was flaky :)

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50897/

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50902/

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50907/

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50909/

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50912/

deokjinkim commented Apr 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@MoLow Commit title has typo(avilable => available).

MoLow commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

@MoLow Commit title has typo(avilable => available).

thanks, I will amend when landing

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50913/

anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 4, 2023

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 4, 2023
MoLow added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 4, 2023
test_runner: color errors only when colors are available
7ec93fb 
PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
MoLow force-pushed the fix-spec-reporter-fluke branch from d61c703 to 7ec93fb Compare April 4, 2023 16:01

MoLow commented Apr 4, 2023

Copy link
Copy Markdown
Member Author

Landed in 7ec93fb

Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 4, 2023
MoLow merged commit 7ec93fb into nodejs:main Apr 4, 2023
MoLow deleted the fix-spec-reporter-fluke branch April 4, 2023 16:01
github-actions Bot mentioned this pull request Apr 5, 2023
Open
26 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
test_runner: color errors only when colors are available
d7bd288 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
test_runner: color errors only when colors are available
120dc25 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
test_runner: color errors only when colors are available
9c1f7b6 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
test_runner: color errors only when colors are available
bc6511a 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
test_runner: color errors only when colors are available
401d7b1 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test_runner: color errors only when colors are available
ad81687 
PR-URL: #47394
Fixes: #47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
test_runner: color errors only when colors are available
0b32a8c 
PR-URL: nodejs#47394
Fixes: nodejs#47393
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test message/test_runner_output_spec_reporter is flaky

6 participants

Back | FazBrowse Home | New Git URL