FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-http2-large-file flaky on aix by MoLow · Pull Request #47410 · nodejs/node · GitHub

/ node Public

test: mark test-http2-large-file flaky on aix - #47410

Closed
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-http2-large-file flaky on aix#47410
MoLow wants to merge 1 commit into
nodejs:mainfrom
MoLow:mark-http2-large-file-as-flaky

Conversation

MoLow commented Apr 4, 2023

Copy link
Copy Markdown
Member

a mitigation for #47409

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 4, 2023
MoLow added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50934/

MoLow removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
mhdawson approved these changes Apr 4, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50944/

github-actions Bot mentioned this pull request Apr 5, 2023
Open
26 tasks

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50949/

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50954/

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50970/

anonrig commented Apr 5, 2023

Copy link
Copy Markdown
Member

Could we land this manually? The tests are failing because of a different issue.

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50987/

targos commented Apr 6, 2023

Copy link
Copy Markdown
Member

#47450 should make this unnecessary.

MoLow commented Apr 6, 2023

Copy link
Copy Markdown
Member Author

closing in favor of #47450

MoLow closed this Apr 6, 2023
MoLow deleted the mark-http2-large-file-as-flaky branch April 6, 2023 17:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL