FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: update root-certificates to 3.89 by nodejs-github-bot · Pull Request #47429 · nodejs/node · GitHub

/ node Public

crypto: update root-certificates to 3.89 - #47429

Closed
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-root-certificates
ConversationCommits (2)ChecksFiles changed
Closed

crypto: update root-certificates to 3.89#47429
nodejs-github-bot wants to merge 2 commits into
mainfrom
actions/tools-update-root-certificates

Conversation

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of root-certificates to 3.89.

richardlau and others added 2 commits April 5, 2023 20:02
tools: add root certificate update script
3e61ede 
Automates the steps from `doc/contributing/maintaining-root-certs.md`.
Extend "Tools and deps update" workflow to use the new script to update
the root certificates.
crypto: update root certificates to NSS 3.89
56951a9 
This is the certdata.txt[0] from NSS 3.89, released on 2023-03-09.

This is the version of NSS that will ship in Firefox 112 on
2023-04-11.

Certificates removed:
- Network Solutions Certificate Authority
- EC-ACC
- Staat der Nederlanden EV Root CA

[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_89_RTM/lib/ckfw/builtins/certdata.txt
nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. notable-change PRs with changes that should be highlighted in changelogs. labels Apr 5, 2023

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/startup
  • @nodejs/tsc
  • @nodejs/url

github-actions Bot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @nodejs-github-bot.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment.

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 5, 2023

lpinca commented Apr 5, 2023

Copy link
Copy Markdown
Member

I think ADA/URL stuff is unrelated.

richardlau commented Apr 5, 2023

Copy link
Copy Markdown
Member

This was generated from #47425 (comment).

richardlau closed this Apr 5, 2023
richardlau deleted the actions/tools-update-root-certificates branch April 5, 2023 20:06
richardlau mentioned this pull request Apr 5, 2023
Merged

richardlau commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I think ADA/URL stuff is unrelated.

Yeah, I'm a bit confused as they are in the first commit which has the same title as the commit from #47425 but the ADA/URL stuff isn't changed there. I can only guess it's some side-effect of running the workflow fromm an unmerged branch.

The second commit 56951a9, is what I expect, with just tools/certdata.txt and src/node_root_certs.h changed.

anonrig commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@richardlau I don't know if this means anything, but: I cherry-picked and merged Ada's update commit on a different pull request to fix the breaking change introduced with v2. And I forgot to close the existing pull request for updating it.

richardlau commented Apr 5, 2023

Copy link
Copy Markdown
Member

@anonrig I think the extra stuff in the first commit is because the branch from #47425 doesn't contain #47339. No idea why it was merged into the first commit though 🤷.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL