src: get binding data store directly from the realm - #47437
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
legendecas
approved these changes
Apr 6, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Apr 10, 2023
31 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
36 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 25, 2023
Copy link
Copy Markdown
Member
|
This conflicts with the main branch now. |
Sorry, something went wrong.
35 tasks
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm.
joyeecheung
force-pushed
the
binding-map
branch
from
377a2bd to
60c49c3
Compare
April 27, 2023 12:37
Copy link
Copy Markdown
Member
Author
|
Oops, I did a rebase some time ago and I forgot to push. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
29 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 29, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced May 2, 2023
joyeecheung
added a commit
that referenced
this pull request
May 4, 2023
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm. PR-URL: #47437 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 12, 2023
We now store the binding data store in the realm and invoke `Realm::AddBindingData` to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm. PR-URL: #47437 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now store the binding data store in the realm and invoke Realm::AddBindingData to add the binding data, so there is no need to get a reference to the binding data store from the context now, we can just get the reference from the realm.