doc,test: update the v8.startupSnapshot doc and test the example - #47468
Merged
nodejs-github-bot merged 1 commit intoMay 3, 2023
Merged
doc,test: update the v8.startupSnapshot doc and test the example#47468nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
joyeecheung
marked this pull request as draft
April 7, 2023 13:59
This comment was marked as outdated.
joyeecheung
force-pushed
the
snapshot-doc
branch
from
27ca905 to
b8949d8
Compare
April 12, 2023 02:17
joyeecheung
marked this pull request as ready for review
April 12, 2023 02:17
This comment was marked as outdated.
joyeecheung
force-pushed
the
snapshot-doc
branch
from
b8949d8 to
41b91c2
Compare
April 12, 2023 02:19
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
36 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
33 tasks
Copy link
Copy Markdown
Member
Author
|
ping @nodejs/documentation @nodejs/startup for a review |
Sorry, something went wrong.
legendecas
reviewed
Apr 26, 2023
Comment thread
doc/api/v8.md
Outdated
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
May 2, 2023
aymen94
approved these changes
May 3, 2023
targos
pushed a commit
that referenced
this pull request
May 12, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: #47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: #47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: nodejs#47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API is now available to user-land run-time snapshots. So update
the example. This also makes the intention of the examples a bit
clearer and test it in our test suite.
This depends on #47466 and #47467, otherwise the example is broken.