FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: add more QUIC implementation by jasnell · Pull Request #47494 · nodejs/node · GitHub

/ node Public

quic: add more QUIC implementation - #47494

Closed
jasnell wants to merge 9 commits into
nodejs:mainfrom
jasnell:quic-part-4
Closed

quic: add more QUIC implementation#47494
jasnell wants to merge 9 commits into
nodejs:mainfrom
jasnell:quic-part-4

Conversation

jasnell commented Apr 10, 2023

Copy link
Copy Markdown
Member

More implementation details...

jasnell requested review from anonrig and tniessen April 10, 2023 02:47

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 10, 2023
Comment thread src/quic/bindingdata.cc Outdated
Comment thread src/quic/bindingdata.cc Outdated
Comment thread src/quic/defs.h Outdated
Comment thread src/quic/packet.cc Outdated
Comment thread src/quic/packet.cc

This comment was marked as outdated.

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There are relevant test failures AFAICT.

Comment thread src/quic/tlscontext.h

This comment was marked as outdated.

jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 15, 2023

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Apr 17, 2023
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

jasnell added a commit that referenced this pull request Apr 18, 2023
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope

PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

jasnell commented Apr 18, 2023

Copy link
Copy Markdown
Member Author

Landed in 1c3d741

jasnell closed this Apr 18, 2023
targos pushed a commit that referenced this pull request May 2, 2023
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope

PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope

PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope

PR-URL: nodejs#47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL