FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v18.x] lib: fix trailing commas and leftover function from rebasing by danielleadams · Pull Request #47503 · nodejs/node · GitHub

/ node Public

[v18.x] lib: fix trailing commas and leftover function from rebasing - #47503

Closed
danielleadams wants to merge 1 commit into
nodejs:v18.x-stagingfrom
danielleadams:fix-linting
Closed

[v18.x] lib: fix trailing commas and leftover function from rebasing#47503
danielleadams wants to merge 1 commit into
nodejs:v18.x-stagingfrom
danielleadams:fix-linting

Conversation

danielleadams commented Apr 11, 2023
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes remaining linting errors and a leftover function from rebasing #47502.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. v18.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 11, 2023
danielleadams removed timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. whatwg-url Issues and PRs related to the WHATWG URL implementation. needs-ci PRs that need a full CI run. labels Apr 11, 2023
danielleadams added a commit that referenced this pull request Apr 11, 2023
PR-URL: #47503
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Copy link
Copy Markdown
Contributor Author

Landed in 62cbddd

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL