FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

benchmark: add a benchmark for `defaultResolve` by aduh95 · Pull Request #47543 · nodejs/node · GitHub

/ node Public

benchmark: add a benchmark for defaultResolve - #47543

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:bench-resolve
Apr 13, 2023
Merged

benchmark: add a benchmark for defaultResolve#47543
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:bench-resolve

Conversation

aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
anonrig added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 13, 2023

aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor Author

anonrig added the performance Issues and PRs related to the performance of Node.js. label Apr 13, 2023
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
GeoffreyBooth removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 13, 2023
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 13, 2023
anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 13, 2023

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🙌

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
nodejs-github-bot merged commit 4afb25c into nodejs:main Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4afb25c

aduh95 deleted the bench-resolve branch April 13, 2023 20:05
targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL