node-api: test passing NULL to number APIs - #47549
Merged
nodejs-github-bot merged 1 commit intoApr 20, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
gabrielschulhof
marked this pull request as draft
April 13, 2023 18:23
gabrielschulhof
force-pushed
the
pass-null-to-number-apis
branch
from
c0e7eca to
bccd21d
Compare
April 13, 2023 18:32
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gabrielschulhof
force-pushed
the
pass-null-to-number-apis
branch
from
bccd21d to
534e728
Compare
April 13, 2023 18:55
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gabrielschulhof
marked this pull request as ready for review
April 14, 2023 03:25
Copy link
Copy Markdown
Contributor
Author
|
@nodejs/node-api please take a look! |
Sorry, something went wrong.
This was referenced Apr 15, 2023
mhdawson
approved these changes
Apr 18, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Apr 20, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47549 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47549 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47549 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.