FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix split infinitive in Hooks caveat by JakobJingleheimer · Pull Request #47550 · nodejs/node · GitHub

/ node Public

doc: fix split infinitive in Hooks caveat - #47550

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
JakobJingleheimer:esm/correct-split-infinitive-in-doc
Apr 13, 2023
Merged

doc: fix split infinitive in Hooks caveat#47550
aduh95 merged 1 commit into
nodejs:mainfrom
JakobJingleheimer:esm/correct-split-infinitive-in-doc

Conversation

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Apr 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

aduh95 changed the title esm: correct split infinitive in Hooks caveat doc: unsplit infinitive in Hooks caveat Apr 13, 2023
aduh95 changed the title doc: unsplit infinitive in Hooks caveat doc: fix split infinitive in Hooks caveat Apr 13, 2023
aduh95 merged commit 1c3cbf3 into nodejs:main Apr 13, 2023

aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Landed in 1c3cbf3

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47550
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
targos mentioned this pull request May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL