FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

esm: initialize `import.meta` on eval by aduh95 · Pull Request #47551 · nodejs/node · GitHub

/ node Public

esm: initialize import.meta on eval - #47551

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:import-meta-eval
Apr 19, 2023
ConversationCommits (1)ChecksFiles changed
Merged

esm: initialize import.meta on eval#47551
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:import-meta-eval

Conversation

aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Apr 13, 2023
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 14, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2023

nodejs-github-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51269/

github-actions Bot mentioned this pull request Apr 15, 2023
Open
33 tasks
github-actions Bot mentioned this pull request Apr 18, 2023
Open
35 tasks

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51339/

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51347/

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51349/

nodejs-github-bot commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51355/

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 19, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
nodejs-github-bot merged commit ee08c70 into nodejs:main Apr 19, 2023

nodejs-github-bot commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in ee08c70

aduh95 deleted the import-meta-eval branch April 19, 2023 20:55
targos pushed a commit that referenced this pull request May 2, 2023
esm: initialize import.meta on eval
c150976 
PR-URL: #47551
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request May 2, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
esm: initialize import.meta on eval
40fa6e4 
PR-URL: nodejs#47551
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
esm: initialize import.meta on eval
5de37a1 
PR-URL: #47551
Backport-PR-URL: #50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: initialize import.meta on eval
562a477 
PR-URL: nodejs/node#47551
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
esm: initialize import.meta on eval
740eae8 
PR-URL: nodejs/node#47551
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

GeoffreyBooth GeoffreyBooth approved these changes
guybedford guybedford approved these changes
JakobJingleheimer JakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

ESM Loaders: Stable (CJS parity)

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL