FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

node-api: test passing NULL to napi_define_class by gabrielschulhof · Pull Request #47567 · nodejs/node · GitHub

/ node Public

node-api: test passing NULL to napi_define_class - #47567

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
gabrielschulhof:pass-null-to-napi_define_class
Apr 26, 2023
ConversationCommits (1)ChecksFiles changed
Merged

node-api: test passing NULL to napi_define_class#47567
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
gabrielschulhof:pass-null-to-napi_define_class

Conversation

gabrielschulhof commented Apr 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

nodejs-github-bot commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Apr 15, 2023

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51402/

This was referenced Apr 24, 2023
Open
Open

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51464/

mhdawson approved these changes Apr 25, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2023

nodejs-github-bot commented Apr 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51466/

github-actions Bot mentioned this pull request Apr 26, 2023
Open
36 tasks
lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 26, 2023
nodejs-github-bot merged commit 11f97d4 into nodejs:main Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 11f97d4

github-actions Bot mentioned this pull request Apr 27, 2023
Open
35 tasks
toyobayashi mentioned this pull request Apr 27, 2023
Merged
github-actions Bot mentioned this pull request Apr 28, 2023
Open
29 tasks
github-actions Bot mentioned this pull request Apr 29, 2023
Open
32 tasks
This was referenced Apr 30, 2023
Open
Open
targos pushed a commit that referenced this pull request May 2, 2023
node-api: test passing NULL to napi_define_class
4d02901 
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos mentioned this pull request May 2, 2023
Merged
gabrielschulhof deleted the pass-null-to-napi_define_class branch May 20, 2023 01:05
gabrielschulhof restored the pass-null-to-napi_define_class branch May 20, 2023 14:41
gabrielschulhof deleted the pass-null-to-napi_define_class branch June 3, 2023 18:10
gabrielschulhof restored the pass-null-to-napi_define_class branch June 5, 2023 02:21
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
node-api: test passing NULL to napi_define_class
6735637 
PR-URL: #47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
node-api: test passing NULL to napi_define_class
beaad7f 
PR-URL: nodejs#47567
Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
gabrielschulhof deleted the pass-null-to-napi_define_class branch December 30, 2024 19:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas Awaiting requested review from legendecas
1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL