tools: automate v8 patch update - #47594
Merged
nodejs-github-bot merged 7 commits intoApr 26, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mscdex
reviewed
Apr 17, 2023
Comment thread
tools/dep_updaters/update-v8-patch.sh
Outdated
Copy link
Copy Markdown
Member
|
Did you consider using the git node command? For the V8 clone, in the canary repo we use the GitHub actions cache |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@targos I basically copied what git node v8 minor was doing, I tried with the command but I had some issue with folder structure. I guess we can cache the v8 clone, should we create a new action specificly for this? |
Sorry, something went wrong.
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
03b4a51 to
f8da622
Compare
April 21, 2023 10:28
Copy link
Copy Markdown
Member
Author
|
I have created a separate action to update v8, caching the git node v8 folder. @targos |
Sorry, something went wrong.
ShogunPanda
approved these changes
Apr 21, 2023
targos
suggested changes
Apr 21, 2023
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
tools/dep_updaters/update-v8-minor.sh
Outdated
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
f912fa3 to
0a46fe1
Compare
April 21, 2023 15:59
targos
reviewed
Apr 24, 2023
Comment thread
.github/workflows/tools.yml
Outdated
Comment thread
tools/dep_updaters/update-v8-patch.sh
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Member
Author
|
sorry for changing my mind a few times but due to the amount of dependencies I've decided to move it back to update-v8.yml |
Sorry, something went wrong.
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
97e3b47 to
936482c
Compare
April 24, 2023 09:27
targos
reviewed
Apr 24, 2023
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
Comment thread
.github/workflows/update-v8.yml
Outdated
targos
reviewed
Apr 24, 2023
Comment thread
.github/workflows/update-v8.yml
Outdated
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
d115ed1 to
a7c237c
Compare
April 24, 2023 09:57
marco-ippolito
force-pushed
the
feat/automate-v8-update
branch
from
a7c237c to
9e5b634
Compare
April 24, 2023 10:00
targos
reviewed
Apr 24, 2023
Comment thread
.github/workflows/update-v8.yml
Outdated
marco-ippolito
commented
Apr 24, 2023
Comment thread
tools/dep_updaters/update-v8-patch.sh
Outdated
targos
approved these changes
Apr 24, 2023
UlisesGascon
approved these changes
Apr 25, 2023
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47594 Refs: nodejs/security-wg#828 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828
please review carefully, first time approaching v8
if you know a way of creating a patch without cloning v8 (which is very expensive) that would be great
@nodejs/security-wg