FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add the missing LoongArch64 definition in the v8.gyp file. by sunhaiyong1978 · Pull Request #47641 · nodejs/node · GitHub

/ node Public

Add the missing LoongArch64 definition in the v8.gyp file. - #47641

Closed
sunhaiyong1978 wants to merge 1 commit into
nodejs:mainfrom
sunhaiyong1978:main
ConversationCommits (1)ChecksFiles changed
Closed

Add the missing LoongArch64 definition in the v8.gyp file.#47641
sunhaiyong1978 wants to merge 1 commit into
nodejs:mainfrom
sunhaiyong1978:main

Conversation

sunhaiyong1978 commented Apr 20, 2023

Copy link
Copy Markdown
Contributor

In the tools/v8_gypfiles/v8.gyp file, there is a missing definition for the LoongArch64 architecture (defined as loong64 in v8). This can lead to errors when compiling node.js that supports v8 on the LoongArch64 architecture.

nodejs-github-bot commented Apr 20, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Apr 20, 2023

sunhaiyong1978 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

Modify the title, because the check failed due to the original title being too long.

gengjiawen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51389/

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5331/

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5331/

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5331/

sunhaiyong1978 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

Modify the title again, because the title check failed.

VoltrexKeyva commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

Hey @sunhaiyong1978, it seems like your commit has an invalid user (basically doesn't point to you), make sure you've configured Git with the appropriate details so that you would be shown as a contributor after this gets merged.

This is generally the cause of the incorrect email being used, make sure it is set to the primary email of your GitHub account by running the following:

$ git config --global user.email "<The primary email>"

(Replace <The primary email> with the primary email of your GitHub account)

And then do a force-push.

sunhaiyong1978 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

Okay, I have modified my submission email.

github-actions Bot mentioned this pull request Apr 24, 2023
Open
39 tasks
This was referenced Apr 25, 2023
Open
Open
debadree25 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 26, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2023

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51481/

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5339/

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5339/

nodejs-github-bot commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5339/

github-actions Bot mentioned this pull request Apr 27, 2023
Open
35 tasks

sunhaiyong1978 commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

I received 3 failing checks , but it seems that they are not caused by the pull request I submitted. What should I do next?

nodejs-github-bot commented Apr 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51498/

This was referenced Apr 28, 2023
Open
Open
Open
Open

targos commented May 1, 2023

Copy link
Copy Markdown
Member

Landed in aa6600d

targos closed this May 1, 2023
targos pushed a commit that referenced this pull request May 1, 2023
tools: add the missing LoongArch64 definition in the v8.gyp file
aa6600d 
PR-URL: #47641
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
github-actions Bot mentioned this pull request May 2, 2023
Open
32 tasks
targos pushed a commit that referenced this pull request May 2, 2023
tools: add the missing LoongArch64 definition in the v8.gyp file
d0283ed 
PR-URL: #47641
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos mentioned this pull request May 2, 2023
Merged
targos pushed a commit that referenced this pull request May 3, 2023
tools: add the missing LoongArch64 definition in the v8.gyp file
326c3f1 
PR-URL: #47641
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
gengjiawen gengjiawen approved these changes
richardlau richardlau approved these changes
+3 more reviewers
targos targos approved these changes
aymen94 aymen94 approved these changes
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL