fs: make recursive readdir algorithms iterative by Ethan-Arrowood · Pull Request #47650 · nodejs/node · GitHub

This PR updates the new readdir recursive algorithm to be iterative. This helps avoid potential callstack issues for very large directories.

CI: https://ci.nodejs.org/job/node-test-pull-request/51388/

CI: https://ci.nodejs.org/job/node-test-pull-request/51390/

Co-authored-by: mscdex <mscdex@users.noreply.github.com>

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Thank you for the great recommendations @mscdex

I have made all the changes and thought I haven't timed it, the tests are running noticeably faster on my local machine 😄

Is there anything blocking this from merging?

CI: https://ci.nodejs.org/job/node-test-pull-request/51720/

Since 7 days have passed since you opened this PR, we can merge this with only 1 review, but I prefer to wait a couple of days to receive a review from @nodejs/fs team.

Since 7 days have passed since you opened this PR, we can merge this with only 1 review, but I prefer to wait a couple of days to receive a review from @nodejs/fs team.

I will take a look later

CI: https://ci.nodejs.org/job/node-test-pull-request/51729/

CI: https://ci.nodejs.org/job/node-test-pull-request/51734/

Landed in 12a93ce

PR-URL: #47650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: nodejs#47650 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Apr 20, 2023

fs: make readdir recursive algorithm iterative

28fc566

Ethan-Arrowood force-pushed the improve-recursive-algs branch from 7de1599 to 28fc566 Compare April 20, 2023 19:46

Ethan-Arrowood changed the title fs: make recursive readdir and opendir algorithms iterative fs: make recursive readdir algorithms iterative Apr 20, 2023

Ethan-Arrowood marked this pull request as ready for review April 20, 2023 19:48

anonrig reviewed Apr 20, 2023

View reviewed changes

Comment thread lib/fs.js

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js

Comment thread lib/fs.js Outdated

Comment thread lib/fs.js Outdated

review suggestions

f15aa53

anonrig approved these changes Apr 20, 2023

View reviewed changes

anonrig added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 20, 2023

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2023

anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 20, 2023

mscdex reviewed Apr 21, 2023

View reviewed changes