doc,fs: update description of fs.stat() method - #47654
Merged
nodejs-github-bot merged 5 commits intoApr 23, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
RaisinTen
reviewed
Apr 21, 2023
Copy link
Copy Markdown
Member
Author
|
Thank you very much for the review and corrections. @RaisinTen |
Sorry, something went wrong.
Co-authored-by: Darshan Sen <raisinten@gmail.com>
Co-authored-by: Darshan Sen <raisinten@gmail.com>
RaisinTen
approved these changes
Apr 21, 2023
RaisinTen
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
cc @nodejs/fs
Sorry, something went wrong.
VoltrexKeyva
approved these changes
Apr 21, 2023
anonrig
approved these changes
Apr 21, 2023
targos
reviewed
Apr 21, 2023
Comment thread
doc/api/fs.md
Outdated
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Member
Author
|
@targos Thank you very much for your suggestion, I sent a commit |
Sorry, something went wrong.
lpinca
approved these changes
Apr 21, 2023
daeyeon
approved these changes
Apr 22, 2023
LiviaMedeiros
approved these changes
Apr 22, 2023
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47654 Fixes: #47633 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47654 Fixes: #47633 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47654 Fixes: nodejs#47633 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi as mentioned in the talk, fs.stat watches the symlinks, while fs.lstat looks at the symlinks themselves. For this reason, it is recommended to use fs.lstat in cases where symlinks themselves need to be looked at. Based on this information I added that you should use fs.stat or fs.lstat depending on the type of file
Fixes: #47633