src: fix creating an ArrayBuffer from a Blob created with openAsBlob - #47691
Closed
daeyeon wants to merge 1 commit into
Closed
src: fix creating an ArrayBuffer from a Blob created with openAsBlob#47691daeyeon wants to merge 1 commit into
daeyeon wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
daeyeon
marked this pull request as draft
April 24, 2023 05:54
daeyeon
force-pushed
the
main.fix/47683-230424.Mon.d73a
branch
from
2b97826 to
babd5a0
Compare
April 24, 2023 06:03
daeyeon
marked this pull request as ready for review
April 24, 2023 06:15
Copy link
Copy Markdown
|
Thanks! Assume the fix should also apply to .stream() - the issue manifested in both .arrayBuffer() and .stream() but reported for arrayBuffer() as that was simpler repro, but perhaps worth adding a test for stream as well? |
Sorry, something went wrong.
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.fix/47683-230424.Mon.d73a
branch
from
babd5a0 to
6e40de0
Compare
April 25, 2023 03:00
Copy link
Copy Markdown
Member
Author
|
@ikreymer That would be better. Updated the test for stream also, PTAL. |
Sorry, something went wrong.
Copy link
Copy Markdown
Yes, that looks good - thanks! |
Sorry, something went wrong.
This comment was marked as outdated.
jasnell
approved these changes
Apr 26, 2023
35 tasks
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #47683
This fixes creating an ArrayBuffer from a Blob sliced from a Blob created with fs.openAsBlob.
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com