doc: mark signing the binary is macOS and Windows only in single-executable docs - #47722
Merged
nodejs-github-bot merged 1 commit intoApr 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
meixg
force-pushed
the
single-executable
branch
from
87f210d to
b689324
Compare
April 26, 2023 08:59
meixg
force-pushed
the
single-executable
branch
from
b689324 to
1e7b49a
Compare
April 26, 2023 09:01
RaisinTen
approved these changes
Apr 26, 2023
aymen94
approved these changes
Apr 26, 2023
VoltrexKeyva
approved these changes
Apr 26, 2023
ovflowd
approved these changes
Apr 26, 2023
mhdawson
approved these changes
Apr 26, 2023
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Ayase-252
approved these changes
Apr 28, 2023
yjl9903
pushed a commit
to yjl9903/node
that referenced
this pull request
Apr 28, 2023
PR-URL: nodejs#47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos
pushed a commit
that referenced
this pull request
May 2, 2023
PR-URL: #47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos
pushed a commit
that referenced
this pull request
May 3, 2023
PR-URL: #47722 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a little confusing for Linux users at steps about signing the binary right now.