benchmark: add bar.R - #47729
Merged
nodejs-github-bot merged 1 commit intoJun 28, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I'm no R expert, so I can't comment on the code, however it might be better to base a new script like this off of the existing scatter.R script instead (notably it doesn't generate the unnecessary table of results like the normal benchmark R script does). |
Sorry, something went wrong.
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Copy link
Copy Markdown
Member
Author
|
Sorry delay. That should be ready to review now. cc: @nodejs/performance |
Sorry, something went wrong.
anonrig
approved these changes
Jun 27, 2023
marco-ippolito
approved these changes
Jun 28, 2023
RafaelGSS
added a commit
that referenced
this pull request
Jul 3, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#47729 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: nodejs#47729 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 10, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #47729 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a few Node.js benchmarks and generating a barplot is quite helpful for comparisons when the standard deviation is slight. I'm using the bar.R in my next report and I thought would be good to have it available in the benchmark folder.
Example: