test: migrate a pseudo_tty test to use assertSnapshot - #47803
Merged
nodejs-github-bot merged 2 commits intoMay 4, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
MoLow
marked this pull request as draft
May 1, 2023 18:01
MoLow
marked this pull request as ready for review
May 1, 2023 20:06
ljharb
reviewed
May 1, 2023
Comment thread
test/common/assertSnapshot.js
Outdated
GeoffreyBooth
approved these changes
May 1, 2023
Comment thread
test/common/assertSnapshot.js
Outdated
Comment thread
test/fixtures/test-runner/output/default_output.snapshot
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Could we run these with ANSI colors support disabled to make easier-to-read snapshots?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
the entire purpose of this test is to test the colors and the reporter
Sorry, something went wrong.
Comment thread
test/parallel/test-runner-output.mjs
Outdated
MoLow
force-pushed
the
migrate-psuedo-tty
branch
2 times, most recently
from
b6f9dfd to
12913f5
Compare
May 2, 2023 05:21
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
benjamingr
approved these changes
May 2, 2023
33 tasks
Copy link
Copy Markdown
Member
Author
|
I spend hours to get a working Windows environment to figure out why tests were failing when it turns out this is the original behavior 😂 : node/test/pseudo-tty/testcfg.py Lines 143 to 145 in 76ae7be |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
28 tasks
benjamingr
approved these changes
May 4, 2023
22 tasks
targos
pushed a commit
that referenced
this pull request
May 12, 2023
PR-URL: #47803 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47803 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47803 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is another followup for #47498 enabling running pseudo-tty snapshot tests