FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: block requiring `test/reporters` without scheme by MoLow · Pull Request #47831 · nodejs/node · GitHub

/ node Public

module: block requiring test/reporters without scheme - #47831

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:fix-test-reporters-schema
May 5, 2023
ConversationCommits (2)ChecksFiles changed
Merged

module: block requiring test/reporters without scheme#47831
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
MoLow:fix-test-reporters-schema

Conversation

MoLow commented May 3, 2023

Copy link
Copy Markdown
Member

Fixes: #47828

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules
  • @nodejs/startup

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 3, 2023

VoltrexKeyva commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

s/shcema/scheme in commit message.

targos commented May 3, 2023

Copy link
Copy Markdown
Member

It should be scheme (or prefix), not schema.

MoLow force-pushed the fix-test-reporters-schema branch from 957ba10 to 92c05c2 Compare May 3, 2023 08:13
panva changed the title module: block requiring test/reporters without shcema module: block requiring test/reporters without scheme May 3, 2023
MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51598/

RaisinTen approved these changes May 3, 2023
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but should we also add a test that requiring this without the scheme throws?

MoLow commented May 3, 2023

Copy link
Copy Markdown
Member Author

@RaisinTen added a test, can you please re-approve?

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023
RaisinTen approved these changes May 3, 2023
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, still LGTM

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51607/

ljharb commented May 3, 2023

Copy link
Copy Markdown
Member

Is this not a breaking change?

MoLow commented May 3, 2023

Copy link
Copy Markdown
Member Author

Is this not a breaking change?

no, it is a bugfix. according to documentation:

This module is only available under the node: scheme. The following will not work:

ljharb commented May 3, 2023

Copy link
Copy Markdown
Member

I get that you can call it a patch, but it will be a breakage for anyone using is-core-module, including anyone using resolve.

targos commented May 3, 2023

Copy link
Copy Markdown
Member

Anyone using it? Really? Don't they have to pass test/reporters to it?

ljharb commented May 3, 2023

Copy link
Copy Markdown
Member

What i mean is, tooling based on resolve will consider the schemeless one a core module. So yes, they’d have to be requiring it, but it’s a pretty big assumption that nobody’s doing that already.

benjamingr commented May 3, 2023

Copy link
Copy Markdown
Member

What i mean is, tooling based on resolve will consider the schemeless one a core module

So I checked is-core-module and found inspect-js/is-core-module@9d5341a from 3 weeks ago so it doesn't look like a lot of time passed and the breakage seems reasonable in this case to not require a major.

On a different note next time you see this sort of bug or oddity please report it :]

aduh95 approved these changes May 3, 2023
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, I agree it makes sense to land this as a patch

ljharb commented May 3, 2023

Copy link
Copy Markdown
Member

@benjamingr the bug or oddity imo is that test requires the scheme, and the only rationale i was aware of for requiring it was that test might be something people are already using. test/reporters didn't seem like it had that rationale.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51615/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
This was referenced May 4, 2023
Open
Open
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
nodejs-github-bot merged commit d55b84b into nodejs:main May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in d55b84b

MoLow deleted the fix-test-reporters-schema branch May 5, 2023 08:46
This was referenced May 6, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
module: block requiring test/reporters without scheme
739113f 
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
module: block requiring test/reporters without scheme
8afdc5b 
PR-URL: #47831
Fixes: #47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
MoLow added a commit to MoLow/node that referenced this pull request Jul 6, 2023
module: block requiring test/reporters without scheme
cf8845d 
PR-URL: nodejs#47831
Fixes: nodejs#47828
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

panva panva approved these changes
benjamingr benjamingr approved these changes
anonrig anonrig approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
aduh95 aduh95 approved these changes
RaisinTen RaisinTen approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test/reporters can be required
Back | FazBrowse Home | New Git URL