FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: allow SIGBUS in signal-handler abort test by targos · Pull Request #47851 · nodejs/node · GitHub

/ node Public

test: allow SIGBUS in signal-handler abort test - #47851

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
targos:test-freebsd-12.4
May 5, 2023
ConversationCommits (3)ChecksFiles changed
Merged

test: allow SIGBUS in signal-handler abort test#47851
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
targos:test-freebsd-12.4

Conversation

targos commented May 4, 2023

Copy link
Copy Markdown
Member

FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134

test: allow SIGBUS in signal-handler abort test
eb4bd35 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 4, 2023
targos mentioned this pull request May 4, 2023
Closed

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51619/

targos commented May 4, 2023

Copy link
Copy Markdown
Member Author

I forced the above CI run to be executed on https://ci.nodejs.org/manage/computer/test-digitalocean-freebsd12-x64-1/ (FreeBSD 12.4)

santigimeno approved these changes May 4, 2023
View reviewed changes
Comment thread test/abort/test-signal-handler.js Outdated
Update test/abort/test-signal-handler.js
9955918 
Co-authored-by: Santiago Gimeno <santiago.gimeno@gmail.com>
targos added the freebsd Issues and PRs related to the FreeBSD platform. label May 4, 2023
targos added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels May 4, 2023

github-actions Bot commented May 4, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @targos. Please 👍 to approve.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2023

nodejs-github-bot commented May 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51621/

mhdawson approved these changes May 4, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

github-actions Bot mentioned this pull request May 5, 2023
Open
22 tasks

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51646/

targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 5, 2023
bnoordhuis approved these changes May 5, 2023
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code change LGTM, no complaints, but I suggest replacing causeSegfault() with abort() because the former contains UB (literal nullptr dereference - compilers are allowed to optimize that away, volatile or not.)

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51651/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
nodejs-github-bot merged commit 3c82d48 into nodejs:main May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3c82d48

targos deleted the test-freebsd-12.4 branch May 5, 2023 11:04
targos added a commit that referenced this pull request May 5, 2023
test: allow SIGBUS in signal-handler abort test
d25c785 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request May 5, 2023
test: allow SIGBUS in signal-handler abort test
02fa528 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request May 5, 2023
test: allow SIGBUS in signal-handler abort test
5dc0fee 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
targos added a commit that referenced this pull request May 5, 2023
test: allow SIGBUS in signal-handler abort test
9bbd991 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: #47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

targos commented May 5, 2023

Copy link
Copy Markdown
Member Author

@nodejs/collaborators if this test fails in your CI runs, you'll have to make sure they include this commit (either by rebasing or starting a fresh node-test-pull-request (don't "resume build"))

debadree25 mentioned this pull request May 5, 2023
Merged
This was referenced May 6, 2023
Open
Open
Open
Open
targos mentioned this pull request May 15, 2023
Merged
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
test: allow SIGBUS in signal-handler abort test
c33c6c6 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
test: allow SIGBUS in signal-handler abort test
d3b857f 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 22, 2023
test: allow SIGBUS in signal-handler abort test
5b88d74 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
mxdvl mentioned this pull request Jun 23, 2023
Merged
erikolofsson pushed a commit to Malterlib/node that referenced this pull request Jun 26, 2023
test: allow SIGBUS in signal-handler abort test
b7a9cf2 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
denihs pushed a commit to meteor/node-v14-esm that referenced this pull request Jun 26, 2023
test: allow SIGBUS in signal-handler abort test
6db6599 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
aduh95 pushed a commit to aduh95/node that referenced this pull request Feb 18, 2025
test: allow SIGBUS in signal-handler abort test
d6fae8e 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
m0th3rch1p pushed a commit to m0th3rch1p/node that referenced this pull request Jul 20, 2025
test: allow SIGBUS in signal-handler abort test
b77000f 
FreeBSD uses SIGBUS after update to v12.4.

Refs: nodejs/build#3134
PR-URL: nodejs#47851
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
santigimeno santigimeno approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
+1 more reviewer
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. freebsd Issues and PRs related to the FreeBSD platform. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL