process: add custom dir support for heapsnapshot-signal - #47854
Merged
Trott merged 1 commit intoSep 5, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
from
18d913b to
577ffbd
Compare
May 4, 2023 11:10
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
2 times, most recently
from
f6baa61 to
98cdeb0
Compare
May 4, 2023 11:32
joyeecheung
reviewed
May 4, 2023
Comment thread
lib/internal/process/pre_execution.js
Outdated
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
from
98cdeb0 to
0cdc46f
Compare
May 5, 2023 03:52
jasnell
approved these changes
May 10, 2023
benjamingr
approved these changes
May 18, 2023
joyeecheung
reviewed
May 19, 2023
Comment thread
lib/internal/process/pre_execution.js
Outdated
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
2 times, most recently
from
5bbc7b0 to
1410a68
Compare
May 20, 2023 06:04
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
from
1410a68 to
3ce5cac
Compare
May 20, 2023 06:16
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
2 times, most recently
from
10b4e01 to
5b1ce48
Compare
May 21, 2023 03:48
joyeecheung
reviewed
May 29, 2023
Comment thread
test/sequential/test-heapdump-flag-custom-dir.js
Outdated
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
2 times, most recently
from
06676d9 to
3f01bc9
Compare
June 9, 2023 09:09
joyeecheung
approved these changes
Jun 10, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This was referenced Jun 11, 2023
Ceres6
reviewed
Aug 14, 2023
Comment thread
lib/internal/process/pre_execution.js
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
2 times, most recently
from
067ee6e to
4e39087
Compare
August 22, 2023 09:10
MrJithil
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
from
4e39087 to
08383f8
Compare
August 22, 2023 09:12
Copy link
Copy Markdown
Member
Author
|
@benjamingr all issues resolved. Please try to land this sooner. Its opened on 4th May. |
Sorry, something went wrong.
Ceres6
reviewed
Aug 22, 2023
Ceres6
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I can't approve, but LGTM
Sorry, something went wrong.
ErickWendel
approved these changes
Sep 5, 2023
ErickWendel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47854 ✔ Done loading data for nodejs/node/pull/47854 ----------------------------------- PR info ------------------------------------ Title process: add custom dir support for heapsnapshot-signal (#47854) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch MrJithil:addCwdSupportOnHeapSnapshot -> nodejs:main Labels process, needs-ci Commits 1 - process: add custom dir support for heapsnapshot-signal Committers 1 - Jithil P Ponnan PR-URL: https://github.com/nodejs/node/pull/47854 Refs: https://github.com/nodejs/node/issues/47842 Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Joyee Cheung Reviewed-By: Erick Wendel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47854 Refs: https://github.com/nodejs/node/issues/47842 Reviewed-By: James M Snell Reviewed-By: Benjamin Gruenbaum Reviewed-By: Joyee Cheung Reviewed-By: Erick Wendel -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 04 May 2023 09:50:48 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1419757000 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1432558181 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/47854#pullrequestreview-1473519728 ✔ - Erick Wendel (@erickwendel): https://github.com/nodejs/node/pull/47854#pullrequestreview-1611054978 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2023-09-05T13:31:34Z: https://ci.nodejs.org/job/node-test-pull-request/53742/ - Querying data for job/node-test-pull-request/53742/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6086313053 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
PR-URL: nodejs#47854 Refs: nodejs#47842 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Trott
force-pushed
the
addCwdSupportOnHeapSnapshot
branch
from
08383f8 to
5402185
Compare
September 5, 2023 22:13
This was referenced Sep 6, 2023
This was referenced Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #47842