src: clarify the parameter name in Permission::Apply - #47874
Merged
nodejs-github-bot merged 3 commits intoMay 7, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.fix/doc/permission-230505.Fri.baaf
branch
from
77416b8 to
21642e7
Compare
May 5, 2023 13:41
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.fix/doc/permission-230505.Fri.baaf
branch
from
1ff3516 to
72cab67
Compare
May 5, 2023 14:53
RafaelGSS
reviewed
May 5, 2023
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This PR does two changes:
- Correctly fix the parameter name deny -> allow
- Use is_all_allowed_ instead of deny_all.
While I 100% agree with the first change, the second one seems odd to me. I feel that reading deny_all_ = true by default way clear than is_all_allowed_ = false
Sorry, something went wrong.
… and worker" This reverts commit 72cab67. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
Copy link
Copy Markdown
Member
Author
|
@RafaelGSS Thanks for the review. I reverted renaming deny_all to follow your opinion. PTAL. |
Sorry, something went wrong.
RafaelGSS
approved these changes
May 6, 2023
RafaelGSS
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with green ci.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
debadree25
approved these changes
May 6, 2023
targos
pushed a commit
that referenced
this pull request
May 12, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
This fixes confusing parameter names. They are references to set allow-permission. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: nodejs#47874 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first parameter is to set allow-permission, but its name declaration is deny. This removes any confusion.
/cc @RafaelGSS
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com