FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: use appropriate usages for a negative import test by panva · Pull Request #47878 · nodejs/node · GitHub

/ node Public

test: use appropriate usages for a negative import test - #47878

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:test-webcrypto-usages
May 7, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: use appropriate usages for a negative import test#47878
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:test-webcrypto-usages

Conversation

panva commented May 5, 2023

Copy link
Copy Markdown
Member

panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels May 5, 2023
nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 5, 2023
panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51653/

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51659/

panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51661/

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51665/

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51668/

github-actions Bot mentioned this pull request May 6, 2023
Open
22 tasks
panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2023
github-actions Bot mentioned this pull request May 7, 2023
Open
27 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2023
nodejs-github-bot merged commit af3750e into nodejs:main May 7, 2023

nodejs-github-bot commented May 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in af3750e

panva deleted the test-webcrypto-usages branch May 7, 2023 11:31
This was referenced May 8, 2023
Open
Open
Open
Open
Open
targos pushed a commit that referenced this pull request May 12, 2023
test: use appropriate usages for a negative import test
8f547af 
Refs: #47864
PR-URL: #47878
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request May 15, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test: use appropriate usages for a negative import test
3029621 
Refs: #47864
PR-URL: #47878
Refs: #47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test: use appropriate usages for a negative import test
7c80439 
Refs: nodejs#47864
PR-URL: nodejs#47878
Refs: nodejs#47864
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL