FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url: call `ada::can_parse` directly by anonrig · Pull Request #47919 · nodejs/node · GitHub

/ node Public

url: call ada::can_parse directly - #47919

Merged
nodejs-github-bot merged 1 commit into
mainfrom
ada-can-parse
May 18, 2023
ConversationCommits (1)ChecksFiles changed
Merged

url: call ada::can_parse directly#47919
nodejs-github-bot merged 1 commit into
mainfrom
ada-can-parse

Conversation

anonrig commented May 8, 2023

Copy link
Copy Markdown
Member

We're planning on improving the performance of ada::can_parse and added this function in 2.3.1 release. This would make things a lot easier and more readable for Node.js.

cc @KhafraDev @nodejs/url

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels May 8, 2023
anonrig requested review from KhafraDev and TimothyGu May 8, 2023 15:44
lemire approved these changes May 8, 2023
View reviewed changes

lemire left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This opens up future optimization opportunities.

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2023

nodejs-github-bot commented May 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51701/

github-actions Bot mentioned this pull request May 9, 2023
Open
29 tasks

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51713/

anonrig commented May 9, 2023

Copy link
Copy Markdown
Member Author

@nodejs/build I couldn't understand the root cause of the error in Test ASan build. Any ideas?

github-actions Bot mentioned this pull request May 10, 2023
Open
25 tasks
jasnell approved these changes May 10, 2023
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Trott commented May 10, 2023

Copy link
Copy Markdown
Member

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

Trott commented May 10, 2023

Copy link
Copy Markdown
Member

LGTM but looks like there's an asan issue in ada::url that needs looking at.

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

Ugh, that link didn't work. You need to scroll back up to line 5393.

anonrig commented May 10, 2023

Copy link
Copy Markdown
Member Author

Because the ASan output is massive and the relevant part can be hard to find, here's a link to the relevant part: https://github.com/nodejs/node/actions/runs/4929741771/jobs/8809762438?pr=47919#step:6:5394

Be patient while it loads. The relevant line starts with ==168106==ERROR:.

@lemire do you have any idea about the root cause of this error?

lemire reviewed May 10, 2023
View reviewed changes
Comment thread src/node_url.cc Outdated
lemire reviewed May 10, 2023
View reviewed changes
Comment thread src/node_url.cc Outdated

lemire commented May 10, 2023

Copy link
Copy Markdown
Member

@Trott I suspect it is not in ada that we have a memory error. See my comment above.

This was referenced May 11, 2023
Open
Open
Open
Open
Open
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2023

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51837/

github-actions Bot mentioned this pull request May 18, 2023
Open
20 tasks
RaisinTen reviewed May 18, 2023
View reviewed changes
Comment thread src/node_url.cc Outdated
anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2023
RaisinTen approved these changes May 18, 2023
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2023

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51865/

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 18, 2023
nodejs-github-bot merged commit 8b6947f into main May 18, 2023
nodejs-github-bot deleted the ada-can-parse branch May 18, 2023 17:49

nodejs-github-bot commented May 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8b6947f

This was referenced May 19, 2023
Open
Open
Open
Open
github-actions Bot mentioned this pull request May 23, 2023
Open
22 tasks
targos pushed a commit that referenced this pull request May 30, 2023
url: call ada::can_parse directly
ebb6536 
PR-URL: #47919
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lemire lemire approved these changes
jasnell jasnell approved these changes
RaisinTen RaisinTen approved these changes
KhafraDev KhafraDev approved these changes
TimothyGu Awaiting requested review from TimothyGu

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL