worker: support more cases when (de)serializing errors - #47925
Merged
nodejs-github-bot merged 6 commits intoMay 12, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
MoLow
force-pushed
the
serialize-more-error-types
branch
from
1ce8d41 to
868e0fb
Compare
May 8, 2023 18:38
Copy link
Copy Markdown
Member
Author
|
CC @nodejs/workers @nodejs/test_runner |
Sorry, something went wrong.
- error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect
MoLow
force-pushed
the
serialize-more-error-types
branch
from
868e0fb to
640f32b
Compare
May 8, 2023 18:50
aduh95
reviewed
May 8, 2023
Comment thread
lib/internal/error_serdes.js
Outdated
aduh95
reviewed
May 8, 2023
Comment thread
test/parallel/test-error-serdes.js
aduh95
reviewed
May 10, 2023
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you add tests with Object.defineProperty(new Error, "cause", { get(){})? When the error cause is defined as a getter on the instance rather than the prototype?
Sorry, something went wrong.
Comment thread
test/parallel/test-error-serdes.js
Outdated
This comment was marked as duplicate.
aduh95
reviewed
May 11, 2023
Comment thread
lib/internal/error_serdes.js
Outdated
aduh95
reviewed
May 11, 2023
Comment thread
lib/internal/error_serdes.js
Comment thread
lib/internal/error_serdes.js
Comment thread
lib/internal/error_serdes.js
Outdated
aduh95
approved these changes
May 11, 2023
Comment thread
test/parallel/test-error-serdes.js
Outdated
benjamingr
approved these changes
May 12, 2023
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 14, 2023
- error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect PR-URL: #47925 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 15, 2023
- error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect PR-URL: #47925 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
- error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect PR-URL: #47925 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
- error.cause is potentially an error, so is now handled recursively - best effort to serialize thrown symbols - handle thrown object with custom inspect PR-URL: nodejs#47925 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extracted from #47867:
the motivation of this change is for the test runner (which runs across multiple processes) to communicate with the main process via v8 serialization instead of TAP - so we want to better serialize a wider range of (edge?) cases