FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: fix ordering of test hooks by philnash · Pull Request #47931 · nodejs/node · GitHub

/ node Public

test_runner: fix ordering of test hooks - #47931

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
philnash:before-before-beforeeach
May 11, 2023
ConversationCommits (3)ChecksFiles changed
Merged

test_runner: fix ordering of test hooks#47931
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
philnash:before-before-beforeeach

Conversation

philnash commented May 9, 2023

Copy link
Copy Markdown
Contributor

For tests with subtests the before hook was being run after the beforeEach hook, which is the opposite to test suites and expectations.

Also, a function was being used to close over the after hooks, but at the point it was being run the after hooks were not yet set up.

Fixes #47915

nodejs-github-bot commented May 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 9, 2023
MoLow reviewed May 9, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js Outdated

MoLow commented May 9, 2023

Copy link
Copy Markdown
Member

please amend the commit message from test: fix ordering of test hooks to test_runner: fix ordering of test hooks

test_runner: fix ordering of test hooks
3ae2015 
For tests with subtests the before hook was being run after the
beforeEach hook, which is the opposite to test suites and expectations.

Also, a function was being used to close over the after hooks, but at
the point it was being run the after hooks were not yet set up.

Fixes nodejs#47915
philnash force-pushed the before-before-beforeeach branch from f08f31f to 3ae2015 Compare May 9, 2023 09:45
philnash changed the title test: fix ordering of test hooks test_runner: fix ordering of test hooks May 9, 2023

philnash commented May 9, 2023

Copy link
Copy Markdown
Contributor Author

I've updated the commit message. Thanks for the review.

MoLow added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 10, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 10, 2023

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51732/

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51740/

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51744/

philnash commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

I can see that some of the Jenkins jobs are failing. Though I'm not sure why. Is there anything I can do to help this?

MoLow commented May 10, 2023

Copy link
Copy Markdown
Member

I can see that some of the Jenkins jobs are failing. Though I'm not sure why. Is there anything I can do to help this?

that is not related to this PR, unfortunately there are some flaky tests

nodejs-github-bot commented May 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51748/

philnash commented May 10, 2023

Copy link
Copy Markdown
Contributor Author

that is not related to this PR, unfortunately there are some flaky tests

Ah, fair enough. Thank you!

MoLow requested a review from cjihrig May 10, 2023 14:25
cjihrig reviewed May 10, 2023
View reviewed changes
Comment thread lib/internal/test_runner/test.js
Comment thread lib/internal/test_runner/test.js
github-actions Bot mentioned this pull request May 11, 2023
Open
24 tasks
MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2023

nodejs-github-bot commented May 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51754/

nodejs-github-bot commented May 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51755/

MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 11, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2023
nodejs-github-bot merged commit 24615bd into nodejs:main May 11, 2023

nodejs-github-bot commented May 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 24615bd

MoLow commented May 11, 2023

Copy link
Copy Markdown
Member

Thanks for the contribution @philnash 🎉

philnash commented May 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the help getting this in @MoLow!

github-actions Bot mentioned this pull request May 12, 2023
Open
23 tasks
targos pushed a commit that referenced this pull request May 12, 2023
test_runner: fix ordering of test hooks
42db1d5 
For tests with subtests the before hook was being run after the
beforeEach hook, which is the opposite to test suites and expectations.

Also, a function was being used to close over the after hooks, but at
the point it was being run the after hooks were not yet set up.

Fixes #47915

PR-URL: #47931
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced May 13, 2023
Open
Open
Open
targos mentioned this pull request May 15, 2023
Merged
This was referenced May 16, 2023
Open
Open
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
test_runner: fix ordering of test hooks
f572b7a 
For tests with subtests the before hook was being run after the
beforeEach hook, which is the opposite to test suites and expectations.

Also, a function was being used to close over the after hooks, but at
the point it was being run the after hooks were not yet set up.

Fixes #47915

PR-URL: #47931
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
test_runner: fix ordering of test hooks
4737314 
For tests with subtests the before hook was being run after the
beforeEach hook, which is the opposite to test suites and expectations.

Also, a function was being used to close over the after hooks, but at
the point it was being run the after hooks were not yet set up.

Fixes nodejs#47915

PR-URL: nodejs#47931
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
MoLow MoLow approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Order of test hooks seems wrong, and is different to the order of hooks for a describe suite

4 participants

Back | FazBrowse Home | New Git URL