doc: fix broken link to TC39 import attributes proposal - #47954
Merged
aduh95 merged 1 commit intoMay 13, 2023
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to.
GeoffreyBooth
approved these changes
May 11, 2023
GeoffreyBooth
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Not necessarily in this PR, but we should probably add some text to the docs saying that once V8 lands support for the new syntax we intend to rename the importAssertions property and other things with the old naming.
Sorry, something went wrong.
aduh95
approved these changes
May 11, 2023
RaisinTen
approved these changes
May 11, 2023
trivikr
approved these changes
May 11, 2023
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47954 ✔ Done loading data for nodejs/node/pull/47954 ----------------------------------- PR info ------------------------------------ Title doc: fix broken link to TC39 import attributes proposal (#47954) Author Rich Trott (@Trott) Branch Trott:import -> nodejs:main Labels doc, author ready Commits 1 - doc: fix broken link to TC39 import attributes proposal Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/47954 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Trivikram Kamat ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47954 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Trivikram Kamat -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 11 May 2023 00:33:34 GMT ✔ Approvals: 4 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/47954#pullrequestreview-1421532048 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/47954#pullrequestreview-1421533486 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47954#pullrequestreview-1421797329 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/47954#pullrequestreview-1421804095 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4964122363 |
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
May 14, 2023
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to. PR-URL: #47954 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 15, 2023
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to. PR-URL: #47954 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to. PR-URL: #47954 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to. PR-URL: nodejs#47954 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The import assertion proposal has been renamed and the old URL does not redirect to the new one. So let's update our URL to point to the import attributes proposal, which is what import assertions have been renamed to.