FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document node-api version process by legendecas · Pull Request #47972 · nodejs/node · GitHub

/ node Public

doc: document node-api version process - #47972

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:node-api/release
May 19, 2023
ConversationCommits (2)ChecksFiles changed
Merged

doc: document node-api version process#47972
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:node-api/release

Conversation

legendecas commented May 12, 2023

Copy link
Copy Markdown
Member

With the change in #45715 landed, there are several code sites that need to be updated with the release Node-API version when a new Node-API version is being released.

This PR adds a document to the guides of a checklist necessary for creating a Node-API release PR.

Fixes: #47664

legendecas added the node-api Issues and PRs related to the Node-API. label May 12, 2023

nodejs-github-bot commented May 12, 2023 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
  • @nodejs/node-api

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 12, 2023

gabrielschulhof commented May 12, 2023

Copy link
Copy Markdown
Contributor

Please also document the process mentioned in #47975 (comment)!

VoltrexKeyva reviewed May 12, 2023
View reviewed changes
Comment thread doc/contributing/releases-node-api.md Outdated

and substitute this guard version with the release version `x`.

#### Step 4. Update test version guards

VoltrexKeyva May 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
#### Step 4. Update test version guards
#### Step 3. Update test version guards

The next step is step 4.

legendecas May 17, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, updated!

Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
gabrielschulhof reviewed May 13, 2023
View reviewed changes

gabrielschulhof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doc looks great! Just a few comments.

Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md Outdated
Comment thread doc/contributing/releases-node-api.md

legendecas commented May 17, 2023

Copy link
Copy Markdown
Member Author

@gabrielschulhof thanks for the suggestions! I've added a section to update the change history and backport the release to LTS lines. Please take a look again.

mhdawson approved these changes May 18, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2023
nodejs-github-bot merged commit 1918241 into nodejs:main May 19, 2023

nodejs-github-bot commented May 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1918241

legendecas deleted the node-api/release branch May 19, 2023 02:50
targos pushed a commit that referenced this pull request May 30, 2023
doc: document node-api version process
0e4a3b7 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
doc: document node-api version process
d60c99a 
PR-URL: #47972
Fixes: #47664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
doc: document node-api version process
c22f739 
PR-URL: nodejs#47972
Fixes: nodejs#47664
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
danielleadams mentioned this pull request Jul 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gabrielschulhof gabrielschulhof approved these changes
RafaelGSS RafaelGSS approved these changes
+3 more reviewers
VoltrexKeyva VoltrexKeyva left review comments
mhdawson mhdawson approved these changes
aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a Node-API release checklist

7 participants

Back | FazBrowse Home | New Git URL