tools: update lint-md-dependencies to @rollup/plugin-commonjs@25.0.0 rollup@3.21.7 - #47995
Merged
nodejs-github-bot merged 1 commit intoMay 17, 2023
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The lint errors being reported by this change are incorrect AFAICT and seem to be fixed by undoing the update of micromark-extension-gfm-table from 1.0.5 to 1.0.6. $ node tools/lint-md/lint-md.mjs doc/README.md
doc/README.md
57:21 warning Cell should be padded with 1 space, not 2 table-cell-padding remark-lint
59:20 warning Cell should be padded table-cell-padding remark-lint
⚠ 2 warnings
$ (cd tools/lint-md/ && npm install micromark-extension-gfm-table@1.0.5) && make lint-md-rollup
changed 1 package, and audited 193 packages in 506ms
129 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
rm -f tools/.*mdlintstamp
cd tools/lint-md && npm ci && npm run build
added 192 packages, and audited 193 packages in 531ms
129 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
> lint-md@1.0.0 build
> rollup -f es -p '@rollup/plugin-node-resolve={exportConditions: ["node"]}' -p @rollup/plugin-commonjs -p rollup-plugin-cleanup lint-md.src.mjs --file lint-md.mjs
lint-md.src.mjs → lint-md.mjs...
created lint-md.mjs in 859ms
$ node tools/lint-md/lint-md.mjs doc/README.md
$ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
A new version of remark-lint-table-cell-padding was published three hours ago to fix the issue here. I'll update this branch. |
Sorry, something went wrong.
Trott
force-pushed
the
actions/tools-update-lint-md-dependencies
branch
from
eb6e725 to
134969b
Compare
May 16, 2023 17:15
Copy link
Copy Markdown
Collaborator
Author
Sorry, something went wrong.
aduh95
approved these changes
May 16, 2023
Copy link
Copy Markdown
Collaborator
Author
Commit Queue failed- Loading data for nodejs/node/pull/47995 ✔ Done loading data for nodejs/node/pull/47995 ----------------------------------- PR info ------------------------------------ Title tools: update lint-md-dependencies to @rollup/plugin-commonjs@25.0.0 rollup@3.21.7 (#47995) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-lint-md-dependencies -> nodejs:main Labels tools, author ready Commits 1 - tools: update remark-preset-lint-node to 4.0.0 Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/47995 Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47995 Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 14 May 2023 00:25:59 GMT ✔ Approvals: 1 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/47995#pullrequestreview-1429568755 ✘ This PR needs to wait 96 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4997612820 |
Sorry, something went wrong.
RaisinTen
approved these changes
May 17, 2023
targos
pushed a commit
that referenced
this pull request
May 30, 2023
PR-URL: #47995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
PR-URL: nodejs#47995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of lint-md-dependencies to @rollup/plugin-commonjs@25.0.0 rollup@3.21.7.