doc: fix typo in binding functions - #48003
Merged
nodejs-github-bot merged 1 commit intoMay 16, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`).
RaisinTen
approved these changes
May 14, 2023
daeyeon
approved these changes
May 15, 2023
HarshithaKP
approved these changes
May 15, 2023
lpinca
approved these changes
May 15, 2023
aymen94
approved these changes
May 16, 2023
targos
pushed a commit
that referenced
this pull request
May 30, 2023
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`). PR-URL: #48003 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`). PR-URL: #48003 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be `util`(not `utils`). PR-URL: nodejs#48003 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to usage(node::util::RegisterExternalReferences) of below line, namespace has to be util(not utils).