FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: updated process.versions properties by Basa198 · Pull Request #48019 · nodejs/node · GitHub

/ node Public

doc: updated process.versions properties - #48019

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Basa198:docsUpdatedprocess.versions
May 17, 2023
ConversationCommits (1)ChecksFiles changed
Merged

doc: updated process.versions properties#48019
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Basa198:docsUpdatedprocess.versions

Conversation

Basa198 commented May 15, 2023 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Added process.versions properties in docs:
uvwasi
undici
acorn
base64
cjs_module_lexer

Before

After

Fixes: #48016

nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels May 15, 2023
Basa198 changed the title docs: updated process.versions properties doc: updated process.versions properties May 15, 2023
debadree25 reviewed May 15, 2023
View reviewed changes

debadree25 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we could replace the entire output with what the latest version of node gives?

{
  node: '19.8.1',
  acorn: '8.8.2',
  ada: '1.0.4',
  ares: '1.19.0',
  brotli: '1.0.9',
  cldr: '42.0',
  icu: '72.1',
  llhttp: '8.1.0',
  modules: '111',
  napi: '8',
  nghttp2: '1.52.0',
  openssl: '1.1.1t',
  simdutf: '3.2.2',
  tz: '2022e',
  undici: '5.21.0',
  unicode: '15.0',
  uv: '1.44.2',
  uvwasi: '0.0.16',
  v8: '10.8.168.25-node.12',
  zlib: '1.2.11'
}

There's a small difference that node now prints everything alphabetically ordered

targos commented May 15, 2023

Copy link
Copy Markdown
Member

Here's the output with main:

{
  node: '21.0.0-pre',
  acorn: '8.8.2',
  ada: '2.4.0',
  ares: '1.19.0',
  base64: '0.5.0',
  brotli: '1.0.9',
  cjs_module_lexer: '1.2.2',
  cldr: '43.0',
  icu: '73.1',
  llhttp: '8.1.0',
  modules: '115',
  napi: '8',
  nghttp2: '1.52.0',
  nghttp3: '0.7.0',
  ngtcp2: '0.8.1',
  openssl: '3.0.8+quic',
  simdutf: '3.2.9',
  tz: '2023c',
  undici: '5.22.0',
  unicode: '15.0',
  uv: '1.44.2',
  uvwasi: '0.0.16',
  v8: '11.3.244.8-node.9',
  zlib: '1.2.13'
}

I think we should take it and replace '21.0.0-pre' with 20.2.0 (it will contain cjs_module_lexer and base64)

Basa198 commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for commenting, could you please give more instructions? Should I update the doc/api/process.md with the current versions?

debadree25 commented May 15, 2023

Copy link
Copy Markdown
Contributor

Hey! You can just copy and paste @targos soln in the doc

Basa198 commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

Great! Thank you for being so helpful

deokjinkim reviewed May 15, 2023
View reviewed changes

deokjinkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.

Fixes: https://github.com/nodejs/node/issues/48016

You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Comment thread doc/api/process.md Outdated

deokjinkim May 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As @targos mentioned, please replace '21.0.0-pre' with 20.2.0.

Suggested change
{ node: '21.0.0-pre',
{ node: '20.2.0',

deokjinkim reviewed May 15, 2023
View reviewed changes

deokjinkim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add below line to commit message? With below line, issue will be closed automatically if this PR is merged.

Fixes: https://github.com/nodejs/node/issues/48016

You can find detail guideline below.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Basa198 commented May 15, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for input, anything else?

deokjinkim commented May 15, 2023

Copy link
Copy Markdown
Contributor

Thanks for input, anything else?

For now, first commit's subsystem(docs => doc) is wrong. So, need to change commit title to doc: update process.versions properties. And there are 3 commits, so I recommend you squash 3 commits into 1 because first commit title has violation.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 15, 2023
aduh95 mentioned this pull request May 15, 2023
Closed
debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 15, 2023
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2023
nodejs-github-bot merged commit 1fdcb1c into nodejs:main May 17, 2023

nodejs-github-bot commented May 17, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1fdcb1c

Basa198 deleted the docsUpdatedprocess.versions branch May 25, 2023 14:29
targos pushed a commit that referenced this pull request May 30, 2023
doc: update process.versions properties
85bbaa9 
Fixes: #48016
PR-URL: #48019
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Jun 4, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
richardlau richardlau approved these changes
deokjinkim deokjinkim approved these changes
RaisinTen RaisinTen approved these changes
+3 more reviewers
debadree25 debadree25 left review comments
aymen94 aymen94 approved these changes
Mesteery Mesteery approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation of process.versions should be updated

10 participants

Back | FazBrowse Home | New Git URL